[docs] add design decision record process and template#17665
Merged
Conversation
Contributor
Code Review by Qodo
1. Filename convention mismatch
|
Contributor
PR Summary by QodoAdd ADR process and template under docs/decisions WalkthroughsDescription• Introduce a Design Decision Record (ADR) log for cross-binding Selenium decisions • Document proposal/approval workflow (PR discussion + TLC consensus; merge equals acceptance) • Provide a reusable ADR template including per-binding convergence status tracking Diagramflowchart TD
C(["Contributor"]) --> T["Copy template"] --> PR["Open PR (Proposed)"] --> TLC{"TLC consensus"} --> M["Merge PR"] --> ADR["Decision record"] --> B["Update binding status"]
subgraph Legend
direction LR
_term(["Terminator"]) ~~~ _proc["Process"] ~~~ _dec{"Decision"}
end
High-Level AssessmentThe following are alternative approaches to this PR: 1. Host ADRs in selenium.dev (website repo)
2. Use GitHub Discussions/issues as the canonical decision record
3. Adopt MADR/Nygard format verbatim (no binding-status table)
Recommendation: The PR’s approach (ADRs in-repo, merge-as-acceptance, and a per-binding status table) is the best fit for Selenium’s cross-binding governance: it keeps the canonical record in the review workflow contributors already use, while explicitly tracking convergence across languages. The main thing to validate in review is whether the approval/consensus wording matches current TLC expectations. File ChangesDocumentation (2)
|
diemol
approved these changes
Jun 10, 2026
Contributor
|
Code review by qodo was updated up to the latest commit 9288155 |
This was referenced Jun 11, 2026
Open
AutomatedTester
added
A-needs decision
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💥 What does this PR do?
Adds
docs/decisions/— a lightweight process for recording design decisions that apply across bindings (API shape, cross-binding semantics, deprecation commitments), plus the template for writing one. Decisions are proposed as PRs, discussed on the PR thread and at TLC meetings, and accepted by TLC consensus; the merged file is the canonical record, so settled questions get answered with a link instead of being re-litigated.🔧 Implementation Notes
🤖 AI assistance
💡 Additional Considerations
🔄 Types of changes